test: add tests for TbdexQuoteNotifier
#321
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ethan-tbd
reviewed
Oct 23, 2024
| }); | ||
|
|
||
| group('TbdexQuoteNotifier Stress Tests', () { | ||
| test('High-frequency polling with exponential backoff', () async { |
ethan-tbd
reviewed
Oct 23, 2024
| .thenAnswer((_) async => TestData.getExchange()); | ||
| }); | ||
|
|
||
| group('TbdexQuoteNotifier Stress Tests', () { |
There was a problem hiding this comment.
let's rename this group to just TbdexQuoteNotifier
|
take a look at the tests for |
|
Hey @ethan-tbd Check out the latest changes. |
ethan-tbd
reviewed
Oct 23, 2024
|
|
||
| await mockTbdexQuoteNotifier.startPolling('pfiId', 'exchangeId'); | ||
|
|
||
| verify(() => mockTbdexQuoteNotifier.startPolling(any(), any())).called(1); |
There was a problem hiding this comment.
what's the reason we are using any() here in startPolling()?
ethan-tbd
reviewed
Oct 23, 2024
Comment on lines
37
to
45
| test('should handle maximum retry attempts', () async { | ||
| when(() => mockTbdexQuoteNotifier.pollForQuote(any(), any())) | ||
| .thenThrow(Exception('Network error')); | ||
|
|
||
| await mockTbdexQuoteNotifier.startPolling('pfiId', 'exchangeId'); | ||
|
|
||
| verify(() => mockTbdexQuoteNotifier.startPolling('pfiId', 'exchangeId')) | ||
| .called(1); | ||
| }); |
There was a problem hiding this comment.
you are throwing an Exception here but the test case only checks to see if startPolling() has been called
ethan-tbd
reviewed
Oct 23, 2024
Comment on lines
26
to
35
| test('should handle high-frequency polling with exponential backoff', | ||
| () async { | ||
| when(() => mockTbdexQuoteNotifier.pollForQuote(any(), any())) | ||
| .thenAnswer((_) async => TestData.getQuote()); | ||
|
|
||
| await mockTbdexQuoteNotifier.startPolling('pfiId', 'exchangeId'); | ||
|
|
||
| verify(() => mockTbdexQuoteNotifier.startPolling('pfiId', 'exchangeId')) | ||
| .called(1); | ||
| }); |
There was a problem hiding this comment.
if you want to test the exponential backoff, try verifying how many times getExchange() is called
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces several tests for
TbdexQuoteNotifier.closes #293